Generic TSS #83
Open
Generic TSS #83
+1,000
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this work for transactions that need a specific signer(s)? |
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestBuildOperations(t *testing.T) { |
There was a problem hiding this comment.
should there be a case for t.Run("op_invoke_host_function"...?
aristidesstaffieri
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Making TSS generic - work for all transactions. Implementation of the doc: https://docs.google.com/document/d/1MJ3iyiTbASJp8hq1cTJO_aHDtP3Ko7kpMnKqzjYhITE/edit?tab=t.0
Why
We need to make TSS work for all types of transactions and not just the disbursement use case
Known limitations
N/A
Issue that this PR addresses
#79
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release